-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[www] Blog post meta styles #1561
Conversation
Deploy preview ready! Built with commit eacb60d |
Deploy preview ready! Built with commit eacb60d |
Deploy preview ready! Built with commit eacb60d |
Nice! I like the tweaks. A couple of notes:
|
👍 OK boss! ;-)
Damn how could I forget those! Component it is.
No :-/ |
re query fragments, see the Relay docs https://facebook.github.io/relay/docs/fragment-container.html#composing-fragments Basically a component can create a query fragment which is added to a global namespace and then normal queries can include the fragment. This is a perfect fit for problems like this where a component is used in multiple places and needs to ensure its data is provided as expected. It's obnoxious otherwise to have to keep the required fields in multiple places. |
…ar size" This reverts commit d6576b7 and on top of that gets rid of <small> in favor of `scale` to compensate for Futura rendering a lot smaller than Gyre Schola.
Sweet! Nice refactor :-) Love how clean the blog preview item component is with the fragment. Such a nice pattern. Composable declarative data ❤️ |
On individual post pages, this reduces the author avatar size a little and gives the author info, post meta (and subsequently the post title) a little more room to breathe on
Tablet
and up:For the blog index page, it consolidates author and post date in one line and adjusts typography to match the individual post styles, also reduces the author avatar size, and removes the dark green excerpt font color: