-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] "Adding React Components" docs page #16288
Comments
Also, it's not just React components. Other libraries may also need |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open! As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing! Thanks for being a part of the Gatsby community! 💪💜 |
Sounds like a good idea to me! I saw some questions about web components in the issue queue, too. More instructions on how to integrate various component types would be well received. |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open! As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing! Thanks for being a part of the Gatsby community! 💪💜 |
I can try to do this. No promises though. Edit: PR is open for business: #18651 This is my first contribution. Please let me know about anything I can do to improve it! |
Summary
As discussed in the Community Maintainers meeting July 24, we discussed it could be useful to have a page describing things to remember when adding React libraries to your Gatsby site.
This could mention things like:
window
object and then mentioning to either use conditionals to check for these or drop these intocomponentDidMount
oruseEffect
so it is only used client-sideIt was brought up that these two pages do have similar content that we could pull from / cross-reference:
@gatsbyjs/learning Is there anything else in particular that could be useful in a page like this? As well, where should this document live as we discussed in the meeting, having a high discoverability for this is important.
The text was updated successfully, but these errors were encountered: