Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] "Adding React Components" docs page #16288

Closed
lannonbr opened this issue Aug 1, 2019 · 5 comments · Fixed by #18651
Closed

[docs] "Adding React Components" docs page #16288

lannonbr opened this issue Aug 1, 2019 · 5 comments · Fixed by #18651
Assignees
Labels
help wanted Issue with a clear description that the community can help with. type: documentation An issue or pull request for improving or updating Gatsby's documentation

Comments

@lannonbr
Copy link
Contributor

lannonbr commented Aug 1, 2019

Summary

As discussed in the Community Maintainers meeting July 24, we discussed it could be useful to have a page describing things to remember when adding React libraries to your Gatsby site.

This could mention things like:

  • Looking out for components that depend on the window object and then mentioning to either use conditionals to check for these or drop these into componentDidMount or useEffect so it is only used client-side
  • Components that may not have SSR support by default, and then looking for methods to add SSR

It was brought up that these two pages do have similar content that we could pull from / cross-reference:

@gatsbyjs/learning Is there anything else in particular that could be useful in a page like this? As well, where should this document live as we discussed in the meeting, having a high discoverability for this is important.

@lannonbr lannonbr added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Aug 1, 2019
@alexluong
Copy link
Contributor

Also, it's not just React components. Other libraries may also need window object too. One example is firebase and everything around it.

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Aug 22, 2019
@gatsbot
Copy link

gatsbot bot commented Aug 22, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@marcysutton marcysutton removed the stale? Issue that may be closed soon due to the original author not responding any more. label Aug 23, 2019
@marcysutton
Copy link
Contributor

Sounds like a good idea to me! I saw some questions about web components in the issue queue, too. More instructions on how to integrate various component types would be well received.

@marcysutton marcysutton added the help wanted Issue with a clear description that the community can help with. label Aug 26, 2019
@gatsbot
Copy link

gatsbot bot commented Sep 16, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Sep 16, 2019
@marcysutton marcysutton removed the stale? Issue that may be closed soon due to the original author not responding any more. label Sep 16, 2019
@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Oct 7, 2019
@marcysutton marcysutton added Hacktoberfest and removed stale? Issue that may be closed soon due to the original author not responding any more. labels Oct 11, 2019
@gatsbyjs gatsbyjs deleted a comment from gatsbot bot Oct 11, 2019
@davwheat
Copy link
Contributor

davwheat commented Oct 14, 2019

I can try to do this. No promises though.

Edit: PR is open for business: #18651

This is my first contribution. Please let me know about anything I can do to improve it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issue with a clear description that the community can help with. type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants