Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-filesystem): Use forward slashes on relativeDirectory #17048

Merged

Conversation

stefanprobst
Copy link
Contributor

When creating File nodes, gatsby-source-filesystem ensures file paths in forward-slash format for the dir, relativePath and absolutePath fields, but not for relativeDirectory.
This PR fixes that, but I'm not sure if anybody on Windows might rely on the previous behavior?

Related: #16987

@stefanprobst stefanprobst requested a review from a team as a code owner August 24, 2019 09:52
@stefanprobst stefanprobst changed the title fix(gatsby-source-filesystem): Use forward slashed on relativeDirectory fix(gatsby-source-filesystem): Use forward slashes on relativeDirectory Aug 24, 2019
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sidharthachatterjee sidharthachatterjee merged commit 799f657 into gatsbyjs:master Aug 24, 2019
@sidharthachatterjee
Copy link
Contributor

Published in gatsby-source-filesystem@2.1.18

@stefanprobst stefanprobst deleted the slash-relative-directory branch August 28, 2019 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants