Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-plugin-google-analytics): Add more checks of Do Not Track preference #17067

Merged
merged 1 commit into from
Aug 27, 2019
Merged

feat(gatsby-plugin-google-analytics): Add more checks of Do Not Track preference #17067

merged 1 commit into from
Aug 27, 2019

Conversation

crazko
Copy link
Contributor

@crazko crazko commented Aug 25, 2019

Description

This PR adds more specific condition to check whether user wants to send Do Not Track preference.

@crazko crazko requested a review from a team as a code owner August 25, 2019 18:48
@crazko crazko changed the title feat(gatsby-plugin-google-analytics): Add more checks of Do Not Track feat(gatsby-plugin-google-analytics): Add more checks of Do Not Track preference Aug 25, 2019
wardpeet
wardpeet reviewed Aug 26, 2019
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I've added a small nit that uses fewer bytes and does the same thing.

packages/gatsby-plugin-google-analytics/src/gatsby-ssr.js Show resolved Hide resolved
@wardpeet wardpeet added the status: awaiting author response Additional information has been requested from the author label Aug 26, 2019
@crazko crazko added status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response Additional information has been requested from the author labels Aug 26, 2019
wardpeet
wardpeet approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for this PR. Privacy is super important so we love that you made it more robust.

@wardpeet wardpeet merged commit 4fdf0d1 into gatsbyjs:master Aug 27, 2019
@crazko
Copy link
Contributor Author

crazko commented Aug 27, 2019

Thanks!

@crazko crazko deleted the feature/analytics-dnt-enhance branch August 27, 2019 07:24
waltercruz pushed a commit to waltercruz/gatsby that referenced this pull request Sep 8, 2019
@crazko @waltercruz
feat(gatsby-plugin-google-analytics): better dnt (gatsbyjs#17067)
7d84604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crazko @wardpeet