Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-mdx): prevent crash when Markdown syntax error #17135

Merged
merged 3 commits into from
Sep 2, 2019

Conversation

tureki
Copy link
Contributor

@tureki tureki commented Aug 28, 2019

Description

This PR will catch the error from MDX compile. Avoid the develop server crash and show the error message in the browser.

Related Issues

Fixes #16107
Fixes #16502

Before

before

After

after

@tureki tureki requested a review from a team as a code owner August 28, 2019 05:59
@wardpeet
Copy link
Contributor

wardpeet commented Sep 2, 2019

Thanks, this seems to work as expected! I'm not sure why we aren't wrapping the whole function in try-catch.

cc @gatsbyjs/themes

Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you fore finding it and fixing it.

@johno approves so, me too! 👍

@wardpeet wardpeet merged commit ed97891 into gatsbyjs:master Sep 2, 2019
@gatsbot
Copy link

gatsbot bot commented Sep 2, 2019

Holy buckets, @tureki — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Copy link
Contributor

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Thanks! This looks good to me.

Thanks, this seems to work as expected! I'm not sure why we aren't wrapping the whole function in try-catch.

Yeah, good point. I suppose we can roll with this for now and spend some time considering if we want more granular error reporting here in a future PR/issue?

waltercruz pushed a commit to waltercruz/gatsby that referenced this pull request Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding HTML to MDX crashes hot reloader [gatsby-plugin-mdx] Don't crash develop server on broken Markdown
4 participants