Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-sharp): Migrate from overlayWith to composite #17392

Merged
merged 3 commits into from
Sep 5, 2019
Merged

fix(gatsby-plugin-sharp): Migrate from overlayWith to composite #17392

merged 3 commits into from
Sep 5, 2019

Conversation

kevinastone
Copy link
Contributor

Migrate from overlayWith to composite for gatsby-plugin-sharp.

Fixes #17162

@kevinastone kevinastone requested a review from a team as a code owner September 4, 2019 17:43
@kevinastone
Added failing test for gatsbyjs#17162
8c885e7 
Tests running the `gatsby-plugin-sharp` with duotone
@kevinastone
Migrated overlayWith to composite
99dd04b 
`overlayWith` was removed in sharp `v0.23`.  The replacement
(`composite`) provides the superset functionality supporting an array of
images to overlay/composite
@kevinastone kevinastone mentioned this pull request Sep 5, 2019
Closed
@wardpeet wardpeet changed the title Migrate from overlayWith to composite for gatsby-plugin-sharp fix(gatsby-plugin-sharp): Migrate from overlayWith to composite Sep 5, 2019
wardpeet
wardpeet approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a bunch for fixing this! You deserve a cookie! Our users will be happy 🤗

@wardpeet wardpeet merged commit 49913ba into gatsbyjs:master Sep 5, 2019
@gatsbot
Copy link

gatsbot bot commented Sep 5, 2019

Holy buckets, @kevinastone — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@wardpeet
Copy link
Contributor

wardpeet commented Sep 5, 2019

Published in gatsby-plugin-sharp@2.2.20

waltercruz pushed a commit to waltercruz/gatsby that referenced this pull request Sep 8, 2019
@kevinastone @waltercruz
fix(gatsby-plugin-sharp): convert "overlayWith" to "composite" (gatsb…
84b542b 
…yjs#17392)

* Added failing test for gatsbyjs#17162

Tests running the `gatsby-plugin-sharp` with duotone

* Migrated overlayWith to composite

`overlayWith` was removed in sharp `v0.23`.  The replacement
(`composite`) provides the superset functionality supporting an array of
images to overlay/composite

* Specify explcit blend: over mode for sharp composite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sharp v0.23 removed overlayWith breaking gatsby-plugin-sharp
2 participants
@kevinastone @wardpeet