feat(gatsby-plugin-google-analytics): add custom event helper #17612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardpeet
reviewed
Sep 16, 2019
wardpeet
changed the title
Co-Authored-By: Ward Peeters <ward@coding-tech.com>
Co-Authored-By: Ward Peeters <ward@coding-tech.com>
Co-Authored-By: Ward Peeters <ward@coding-tech.com>
|
hitCallback would be useful! Any chance of getting this section pushed (so I can use it in a project I am working on) and then I can come back to this? |
Removed spaces
|
Completely missed that line comment! Sorted now. |
marcysutton
reviewed
Sep 16, 2019
Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
coreyward
suggested changes
Sep 17, 2019
There was a problem hiding this comment.
If we're going to wrap window.ga we should consider incorporating the remaining event options that Google Analytics supports like setting transport: beacon and nonInteraction: true as well: https://developers.google.com/analytics/devguides/collection/analyticsjs/events
Co-Authored-By: Corey Ward <corey.atx@gmail.com>
Co-Authored-By: Ward Peeters <ward@coding-tech.com>
muescha
reviewed
Sep 17, 2019
Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>
muescha
reviewed
Sep 17, 2019
Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>
muescha
reviewed
Sep 18, 2019
muescha
reviewed
Sep 18, 2019
muescha
reviewed
Sep 18, 2019
muescha
reviewed
Sep 18, 2019
Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>
Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>
|
Hey, Working with packages inside massive repos is not something I am used to dealing with. How do I get this to a point that it can be merged? Thanks |
|
I'll give it a final review :) |
|
@wardpeet What are your thoughts? Do I need to merge the upstream before it can be added? |
wardpeet
reviewed
Oct 9, 2019
Co-Authored-By: Ward Peeters <ward@coding-tech.com>
Co-Authored-By: Ward Peeters <ward@coding-tech.com>
Co-Authored-By: Ward Peeters <ward@coding-tech.com>
Co-Authored-By: Ward Peeters <ward@coding-tech.com>
LekoArts
added
the
status: awaiting reviewer response
|
cc @wardpeet |
wardpeet
approved these changes
Nov 13, 2019
There was a problem hiding this comment.
@robmarshall thanks for creating this helper! Sorry, it took so long to get this merged.
Thank you! Let's ship it!
|
Amazing! Thanks @wardpeet, looked over your cleanups, so much nicer! Thanks for the help :) |
m-allanson
added a commit
to sdras/gatsby
that referenced
this pull request
Nov 13, 2019
# By Sidhartha Chatterjee (6) and others # Via Ward Peeters * master: (95 commits) chore(release): Publish fix(gatsby): Use crossorigin for link in linkPrefetch strategy (gatsbyjs#17581) chore(www): Referrer policy (gatsbyjs#18621) feat(gatsby-source-shopify): support multi currency (gatsbyjs#19454) feat(gatsby-plugin-google-analytics): add custom event helper (gatsbyjs#17612) chore(docs): Add documentation for tailwindcss support (gatsbyjs#17747) Grammar fix (gatsbyjs#19473) Update sites.yml (gatsbyjs#19475) test(e2e-tests): add regression test for resolution conflicts… (gatsbyjs#19476) chore(release): Publish chore(docs): link to gatsby-plugin-catch-links in gatsby link… (gatsbyjs#19424) chore(gatsby): remove array.prototype.flatmap (gatsbyjs#19472) fix(gatsby): Re-use plugin resolution logic for theme dir resolution (gatsbyjs#19470) chore: Update stale action (gatsbyjs#19471) chore(showcase): add Kosmos to the showcase (gatsbyjs#19455) chore(showcase): Add Akshay Thakur's Portfolio (gatsbyjs#19370) chore(docs): Add note about file extensions (gatsbyjs#19464) chore(showcase): Add Quema Labs (gatsbyjs#19374) Update starters.yml (gatsbyjs#19375) fix(gatsby-transformer-remark): Check key before trying to get cache (gatsbyjs#19288) ...
rickiesmooth
pushed a commit
to rickiesmooth/gatsby
that referenced
this pull request
Nov 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A custom event tracker for gatsby-plugin-google-analytics.
The user can import function "customTrackingEvent" from the plugin to call a tracking event on dynamic events or events that do not involve a new page loading.
An example would be tracking what filters have been used to dynamically sort items on a page. On each press of the sorting button, the event would fire, and then the items would be sorted. Allowing the website admin to see which combination of events are more used.
The user can provide the following values:
In response to this issue: #17603
I have added a basic test case, wasn't sure how else to test this. I have also added a short snippet for the documentation.
Let me know thoughts/improvements.
Thanks!