-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-transformer-remark): Handle CJK characters for timeToRead #18303
Conversation
After reading wiki I found that Korean Hangul is separated by spaces so they are covered by original count. So it's actually count CJ for timeToRead |
@Austaras Perhaps some tests here might help? |
test added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this @Austaras 🥇
Holy buckets, @Austaras — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Description
Currently gatsby-transformer-remark uses lodash.words to count words for timeToRead which only count latin characters. This PR make it also count CJK characters
Related Issues
Fixes #17988