Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-typescript): add support for numeric separators #19610

Merged
merged 1 commit into from
Nov 19, 2019
Merged

feat(gatsby-plugin-typescript): add support for numeric separators #19610

merged 1 commit into from
Nov 19, 2019

Conversation

lsanwick
Copy link
Contributor

Description

Similar to #19302, TypeScript has supported numeric separators since v2.7. As they are a Stage 3 proposal, I believe it's reasonable to add them to the configuration here so that Gatsby TypeScript users aren't surprised when numeric separators don't compile.

@lsanwick lsanwick requested a review from a team as a code owner November 19, 2019 05:21
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thank you for your contribution :)

@pvdz pvdz added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Nov 19, 2019
@sidharthachatterjee sidharthachatterjee merged commit 2921221 into gatsbyjs:master Nov 19, 2019
@gatsbot
Copy link

gatsbot bot commented Nov 19, 2019

Holy buckets, @lsanwick — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@lsanwick lsanwick deleted the ls/numeric-separator branch November 19, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants