fix(gatsby-plugin-sharp): fix progressbar & caching layer #19717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardpeet
changed the title
wardpeet
changed the title
|
I made it do less than before as the pre 2.30 version shows 80 and the new one is doing 74. It's not a bug, we process an input file twice which isn't happening with the new code as my check is much more early. |
pieh
previously approved these changes
Nov 22, 2019
| let finishedPromise = Promise.resolve() | ||
|
|
||
| // Check if the output file already exists so we don't redo work. | ||
| if (cachedOutputFiles.has(outputFile)) { | ||
| finishedPromise = cachedOutputFiles.get(outputFile) |
There was a problem hiding this comment.
Should we return early here to avoid && !cachedOutputFiles.has(outputFile) check in L116
pieh
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes order of
reporterparams to fix progressbar. Also added caching layer for ouputFile back. If an outputPath is already scheduled we return the same promise, this was overlooked by me in the worker fix. It doesn't show in simple examples.Test version:
npm install --save gatsby-plugin-sharp@sharp-cacheBefore the scheduleJob api was the same as we have in this PR.
gatsby/packages/gatsby-plugin-sharp/src/scheduler.js
Lines 54 to 60 in f9933b1
Pre 2.3.0:
Before:
After:
Related Issues
#19591 (comment)