Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-google-analytics): Value typing #20554

Merged
merged 1 commit into from
Jan 13, 2020
Merged

fix(gatsby-plugin-google-analytics): Value typing #20554

merged 1 commit into from
Jan 13, 2020

Conversation

malcolm-kee
Copy link
Contributor

Description

Fix gatsby-plugin-google-analytics type definition.

The value parameter for trackCustomEvent should be a number instead of string.

Documentation

Docs of this plugin and Google Analytics docs

@malcolm-kee malcolm-kee requested a review from a team as a code owner January 12, 2020 07:09
@malcolm-kee malcolm-kee self-assigned this Jan 12, 2020
@LekoArts LekoArts changed the title Fix gatsby-plugin-google-analytics types fix(gatsby-plugin-google-analytics): Value typing Jan 13, 2020
LekoArts
LekoArts approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@LekoArts LekoArts merged commit b6031bb into gatsbyjs:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees

@malcolm-kee malcolm-kee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malcolm-kee @LekoArts