Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-mdx): Pass node API helpers through mdx-loader to remark plugins #21211

Merged
merged 2 commits into from
Feb 10, 2020
Merged

fix(gatsby-plugin-mdx): Pass node API helpers through mdx-loader to remark plugins #21211

merged 2 commits into from
Feb 10, 2020

Conversation

andrewbranch
Copy link
Contributor

Description

This is a follow-up to #20879, doing exactly the same thing, but from the loader entrypoint rather than the sourceNodes and onCreateNode entrypoints.

@andrewbranch andrewbranch requested a review from a team as a code owner February 5, 2020 02:11
@andrewbranch andrewbranch changed the title Pass node API helpers through mdx-loader to remark plugins fix(gatsby-plugin-mdx) Pass node API helpers through mdx-loader to remark plugins Feb 5, 2020
@andrewbranch andrewbranch changed the title fix(gatsby-plugin-mdx) Pass node API helpers through mdx-loader to remark plugins fix(gatsby-plugin-mdx): Pass node API helpers through mdx-loader to remark plugins Feb 5, 2020
@leafac
Copy link
Contributor

leafac commented Feb 7, 2020

I tested this Pull Request and confirmed that it does fix the original problem I was having. How can I help to get this reviewed, merged, and released?

@Ir1d
Copy link

Ir1d commented Feb 9, 2020

This PR should help a lot. How can we help get this merged?

Copy link
Contributor

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨This lgtm, thanks! Don't know if you have any thoughts @pieh?

@pieh
Copy link
Contributor

pieh commented Feb 10, 2020

No objections from me - if we started this path in #20879 we should finish it probably ;)

@johno johno merged commit 247a183 into gatsbyjs:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants