Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-source-filesystem): Unify publicURL #22328

Conversation

KoltesDigital
Copy link
Contributor

Description

As discussed in #22244, this patch lets gatsby-source-filesystem use the same generated URL as gatsby-remark-copy-linked-files, i.e. the content digest as a parent directory so that the filename does not change.

Documentation

Should it? However it makes sense to notify users that their URLs will probably change.

Related Issues

Fixes #22244 which addressed #9777.

@KoltesDigital KoltesDigital requested a review from a team as a code owner March 16, 2020 11:24
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Yeah this didn't get moved others when the others did. Thanks for fixing this.

@KyleAMathews KyleAMathews merged commit 756d386 into gatsbyjs:master Mar 18, 2020
@gatsbot
Copy link

gatsbot bot commented Mar 18, 2020

Holy buckets, @KoltesDigital — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@KoltesDigital
Copy link
Contributor Author

Thanks!

Huh... while you're here, would you mind having a look at #21782 ? 😉

mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gatsby-source-filesystem's publicURL should keep file name
2 participants