Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-sharp): Apply transformArgs on compressJpg and compressWebP #22538

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

danilobuerger
Copy link
Contributor

@danilobuerger danilobuerger commented Mar 24, 2020

Description

Currently the defaultQuality is not being applied when compressing jpg or webp as the wrong args are used.

Documentation

https://www.gatsbyjs.org/packages/gatsby-plugin-sharp/

Related Issues

Fixes #13807

Currently the `defaultQuality` is not being applied when compressing jpg or webp as the wrong args are used.
@danilobuerger danilobuerger requested a review from a team as a code owner March 24, 2020 09:29
@wardpeet wardpeet changed the title [gatsby-plugin-sharp] Apply transformArgs on compressJpg and compressWebP fix(gatsby-plugin-sharp): Apply transformArgs on compressJpg and compressWebP Mar 24, 2020
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for fixing!

@wardpeet wardpeet merged commit 4fd158f into gatsbyjs:master Mar 24, 2020
@gatsbot
Copy link

gatsbot bot commented Mar 24, 2020

Holy buckets, @danilobuerger — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@danilobuerger danilobuerger deleted the patch-1 branch March 24, 2020 10:43
@pvdz
Copy link
Contributor

pvdz commented Mar 24, 2020

Published in gatsby@2.20.4 and gatsby-plugin-sharp@2.5.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gatsby-plugin-sharp defaultQuality not applied.
3 participants