-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update postcss related plugins #2462
Comments
On creating a PR — check out gatsbyjs.org/docs/how-to-contribute/ |
@KyleAMathews I did - that's how I found the issue with I had an issue when running |
yeah, whenever you run yarn, you have to restart gatsby-dev cause yarn overwrites everything. |
@KyleAMathews I read it all again and I still don't get how to try out gatsby with updated dependencies... If I run I tried using $ yarn
yarn install v1.2.1
[1/4] 🔍 Resolving packages...
[2/4] 🚚 Fetching packages...
[3/4] 🔗 Linking dependencies...
warning "react-helmet@5.2.0" has unmet peer dependency "react@>=15.0.0".
error An unexpected error occurred: "ENOENT: no such file or directory, lstat '/Users/.../my_repo/node_modules/gatsby/node_modules/hoek/.travis.yml'". For now, I added Any tips? :) |
Hmm yeah updated dependencies like this are hard to test. I am wary of doing major updates on large dependencies though. V2 is coming out soon. Could you look over the v2 branch and see if things look good? |
Sure, I can prepare this PR for the |
Any progress on this? Seems like an easy enough fix |
I tried to update the |
That's a bummer.. Thanks for the effort though :) |
With #6217 to be released soon, it's no longer needed. |
The current versions of
postcss
related plugins are pretty outdated, i.e.:postcss-cssnext
^2.8.0
3.0.2
postcss-import
^8.2.0
11.0.0
postcss-loader
^0.13.0
2.0.8
postcss-reporter
^1.4.1
5.0.0
The main reason why I looked into it, is that
postcss-reporter
version used bygatsby
has a small issue where it prints outundefined [undefined]
for every@import ...
in*.module.css
files when building the app, e.g.:It doesn't really break anything - it's just an issue with logging messages (postcss/postcss-import#277 (comment)).
It looks like neither of these plugins introduced a serious breaking changes for end users, so updating them shouldn't cause any bigger issues.
I tried to create a PR, but I can't figure out how to use version of
gatsby
with updated dependencies in my own project -yarn
was either overwriting the linked version or it kept the old dependencies...The text was updated successfully, but these errors were encountered: