Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-filesystem): Update typings for createRemoteFileNode #24750

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Jun 3, 2020

Description

This PR fixes broken typings of createRemoteFileNode (in gatsby-source-filesystem).

Using NodePluginArgs["cache"] instead of GatsbyCache because it is compatible with both - new and old versions of gatsby. Using GatsbyCache will only work with gatsby@^2.22.13 and will break with older versions.

Documentation

N/A

Related Issues

Fixes #24735

@vladar vladar requested a review from a team as a code owner June 3, 2020 12:41
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 3, 2020
@vladar vladar added status: needs core review Currently awaiting review from Core team member and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 3, 2020
@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jun 16, 2020
@gatsbybot gatsbybot merged commit c9a24f9 into master Jun 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the vladar/gh-24735 branch June 16, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes status: needs core review Currently awaiting review from Core team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types for CreateRemoteFileNodeArgs['cache'] are inconsistent with Gatsby types
4 participants