Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-manifest): fix plugin option schema and add a test for it #27565

Merged
merged 3 commits into from
Oct 27, 2020
Merged

fix(gatsby-plugin-manifest): fix plugin option schema and add a test for it #27565

merged 3 commits into from
Oct 27, 2020

Conversation

mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Oct 20, 2020

Using the latest version with the experimental feature flag (e.g. in gatsby-starter-blog) results in this error:

warn Plugin "gatsby-plugin-manifest" has an invalid options schema so we cannot verify your configuration for it.

[ch17522]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 20, 2020
@mxstbr mxstbr requested a review from a team October 20, 2020 10:55
pvdz
pvdz previously approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix the remnant gatsby-plugin-utils problem?? :D

@pvdz pvdz added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 20, 2020
wardpeet
wardpeet approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxstbr mxstbr merged commit 49fdb53 into master Oct 27, 2020
@mxstbr mxstbr deleted the manifest/fix-plugin-options-schema branch October 27, 2020 12:10
@pieh pieh mentioned this pull request Oct 27, 2020
Merged
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

@pvdz pvdz pvdz left review comments

Assignees
No one assigned
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxstbr @pvdz @wardpeet