feat(gatsby-transformer-sharp): Resolver API changes #27783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
ascorbic
added
topic: sharp
and removed
status: triage needed
pvdz
reviewed
Nov 3, 2020
laurieontech
reviewed
Nov 9, 2020
laurieontech
reviewed
Nov 9, 2020
| @@ -415,6 +415,10 @@ const imageNodeType = ({ | |||
| }, | |||
| maxHeight: { | |||
| type: GraphQLInt, | |||
| description: stripIndent` | |||
| If set, the generated image is a maximum of this height, cropping if necessary. | |||
| If the image layout is "constrained" then the image will be limited to this height. | |||
There was a problem hiding this comment.
Is this true? It's limited to maxHeight for constrained unless the original image height is less than that.
added 2 commits
November 9, 2020 13:25
ascorbic
commented
Nov 10, 2020
| @@ -284,7 +284,7 @@ export const query = graphql` | |||
| childImageSharp { | |||
| # Specify the image processing specifications right in the query. | |||
| # Makes it trivial to update as your page's design changes. | |||
| gatsbyImageData(layout: FIXED, width: 125, height: 125) | |||
| gatsbyImageData(layout: FIXED, width: 125, height: 125) | |||
vladar
reviewed
Nov 10, 2020
vladar
approved these changes
Nov 10, 2020
laurieontech
approved these changes
Nov 10, 2020
|
Hello @ascorbic, is this change supposed to work with the current You can see here: https://github.com/didia/didia.me/pull/738/checks?check_run_id=1507185101 |
|
Hi @didia , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following-on from the discussions in #27668, this PR implements the following changes to the resolver:
gatsbyImageresolver, and is instead returned directly. The resolver is renamed togatsbyImageData. The new syntax is:jpgOptions, which are passed to sharp. Eventually we can update the schema to support all relevant sharp options, but currently they just support the same options that were previously supported.blurredOptionsobjecttransformOptionsobjecttoFormatandwebPoptions with a newformatsoption, that accepts an array of formats to generate. The default is[AUTO, WEBP], which should be used in most cases.srcSetBreakpoints. This should be replaced with the equivalentoutputPixelDensitiesvalue.