Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-sitemap): fixed missing sitemapSize config entry #27866

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

me4502
Copy link
Contributor

@me4502 me4502 commented Nov 6, 2020

Description

The Joi configuration validation setup for the sitemap plugin was missing the sitemapSize option, causing builds using the option to fail now that configuration is strictly validated. This adds the Joi entry for this option.

@me4502 me4502 requested a review from a team as a code owner November 6, 2020 01:28
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 6, 2020
@vladar vladar added topic: sitemap and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 6, 2020
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this!

@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Nov 6, 2020
@gatsbybot gatsbybot merged commit f0689ff into gatsbyjs:master Nov 6, 2020
vladar pushed a commit that referenced this pull request Nov 6, 2020
@vladar vladar added the hotfix label Nov 6, 2020
vladar added a commit that referenced this pull request Nov 6, 2020
…27866) (#27876)

(cherry picked from commit f0689ff)

Co-authored-by: Matthew Miller <mnmiller1@me.com>
@me4502 me4502 deleted the fix/sitemap-size branch April 29, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants