Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-google-analytics): add optional options to options schema #27914

Merged
merged 1 commit into from
Nov 9, 2020
Merged

fix(gatsby-plugin-google-analytics): add optional options to options schema #27914

merged 1 commit into from
Nov 9, 2020

Conversation

mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Nov 9, 2020

See https://www.npmjs.com/package/gatsby-plugin-google-analytics#optional-fields for the full list. These were all missing.

Closes #27833

@mxstbr mxstbr requested a review from a team as a code owner November 9, 2020 10:51
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 9, 2020
@wardpeet wardpeet added topic: plugins-analytics Various analytics plugins like gatsby-plugin-google-analytics hotfix and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 9, 2020
@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Nov 9, 2020
@gatsbybot gatsbybot merged commit 3cdf29f into master Nov 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the ga/add-cookieFlags-option-to-schema branch November 9, 2020 12:32
vladar pushed a commit that referenced this pull request Nov 9, 2020
@mxstbr @vladar
fix(gatsby-plugin-google-analytics): add optional options to options …
f808999 
…schema (#27914)

(cherry picked from commit 3cdf29f)
@vladar vladar mentioned this pull request Nov 9, 2020
Merged
@mohsenkhanpour
Copy link

Thanks, cookieFlags (string) is not yet added to schema, please inspect.

vladar added a commit that referenced this pull request Nov 9, 2020
@vladar
fix(gatsby-plugin-google-analytics): add optional options to options …
4725e8b 
…schema (#27914) (#27920)

(cherry picked from commit 3cdf29f)
@mxstbr mxstbr mentioned this pull request Nov 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascorbic ascorbic ascorbic approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: plugins-analytics Various analytics plugins like gatsby-plugin-google-analytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gatsby-plugin-google-analytics: "cookieFlags" is not allowed - Invalid plugin options
6 participants
@mxstbr @mohsenkhanpour @ascorbic @vladar @wardpeet @gatsbybot