Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-google-analytics): add cookieFlags to options schema #27923

Merged
merged 1 commit into from
Nov 9, 2020
Merged

fix(gatsby-plugin-google-analytics): add cookieFlags to options schema #27923

merged 1 commit into from
Nov 9, 2020

Conversation

mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Nov 9, 2020

Actually closes #27833! I added all other options but forgot this one in #27914 🤦

@mxstbr mxstbr requested a review from a team as a code owner November 9, 2020 13:44
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 9, 2020
@vladar vladar added hotfix and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 9, 2020
@mxstbr mxstbr added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Nov 9, 2020
mfrachet
mfrachet approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@mfrachet mfrachet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix ❤️ . No tests for that specific one 😛 ?

@gatsbybot gatsbybot merged commit 557139e into master Nov 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the google-analytics/cookie-flags branch November 9, 2020 14:13
vladar pushed a commit that referenced this pull request Nov 9, 2020
@mxstbr @vladar
fix(gatsby-plugin-google-analytics): add cookieFlags to options schema (
610cbb6 
#27923)

(cherry picked from commit 557139e)
@vladar vladar mentioned this pull request Nov 9, 2020
Merged
vladar added a commit that referenced this pull request Nov 9, 2020
@vladar
fix(gatsby-plugin-google-analytics): add cookieFlags to options schema (
debfca9 
#27923) (#27926)

(cherry picked from commit 557139e)
@vladar
Copy link
Contributor

vladar commented Nov 9, 2020

Published in gatsby-plugin-google-analytics@2.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfrachet mfrachet mfrachet approved these changes

@vladar vladar vladar approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gatsby-plugin-google-analytics: "cookieFlags" is not allowed - Invalid plugin options
4 participants
@mxstbr @vladar @mfrachet @gatsbybot