Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown images with space in filename break #2909

Closed
fk opened this issue Nov 13, 2017 · 6 comments · May be fixed by tejzpr/gatsby#61
Closed

Markdown images with space in filename break #2909

fk opened this issue Nov 13, 2017 · 6 comments · May be fixed by tejzpr/gatsby#61

Comments

@fk
Copy link
Contributor

fk commented Nov 13, 2017

From examples/using-remark-copy-linked-files:

image

@KyleAMathews
Copy link
Contributor

Any idea why? Is this a new thing w/ your PR or an older problem?

@fk
Copy link
Contributor Author

fk commented Nov 13, 2017

Putting together examples/using-remark-copy-linked-files is the first time I have seen it. The images I originally used in the first shot at that example site were from the example Markdown @chiedo posted in #2871 (comment) and most of their names contained a space.

Gimme a second and let me check if this came in with my PR.

@fk
Copy link
Contributor Author

fk commented Nov 13, 2017

Is this a new thing w/ your PR or an older problem?

Older problem, just tested with a local site with gatsby-remark-copy-linked-files@1.5.7
image, same problem already:

image

@Chuloo
Copy link
Contributor

Chuloo commented Aug 29, 2018

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues as many of them have already been resolved with the latest updates or explained in a previous issue.

Feel free to open a new one if you still experience this problem or a similar one! 👍

@Chuloo Chuloo closed this as completed Aug 29, 2018
@fk
Copy link
Contributor Author

fk commented Aug 30, 2018

FWIW this is working—just checked examples/using-remark-copy-linked-files in master (gatsby 2.0.0-rc.4, gatsby-remark-copy-linked-files 2.0.0-rc.1):
image

@clarkd
Copy link

clarkd commented Nov 14, 2018

Will this be fixed in gatsby 1 at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants