Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid plugin options "related_applications" gatsby-plugin-manifest #29112

Closed
samponeill opened this issue Jan 20, 2021 · 3 comments · Fixed by #29193 or #29242
Closed

Invalid plugin options "related_applications" gatsby-plugin-manifest #29112

samponeill opened this issue Jan 20, 2021 · 3 comments · Fixed by #29193 or #29242
Labels
type: question or discussion Issue discussing or asking a question about Gatsby

Comments

@samponeill
Copy link

Adding a webapp as a related application gives me the following:

  • "related_applications[0].platform" must be one of [narrow, wide, chromeos,
    ios, kaios, macos, windows, windows10x, xbox, chrome_web_store, play, itunes,
    microsoft]
  • "related_applications[0].id" is required

whereas w3c options include:
"chrome_web_store": Google Chrome Web Store.
"play": Google Play Store.
"itunes": iTunes App Store.
"webapp": Web apps.
"windows": Windows App Store.

https://github.com/w3c/manifest/wiki/Platforms

Is it possible to add the above options and disable the requirement for id for webapps?

@samponeill samponeill added the type: bug An issue or pull request relating to a bug in Gatsby label Jan 20, 2021
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 20, 2021
@samponeill samponeill changed the title Invalid plugin options "related_applications" Invalid plugin options "related_applications" gatsby-plugin-manifest Jan 21, 2021
@LekoArts LekoArts added type: question or discussion Issue discussing or asking a question about Gatsby and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer type: bug An issue or pull request relating to a bug in Gatsby labels Jan 22, 2021
@LekoArts
Copy link
Contributor

Thank you for opening this!

As per the W3 spec you need to have an id or url: https://www.w3.org/TR/appmanifest/#externalapplicationresource-and-its-members

So our error logging is working as expected here.

We're marking this issue as answered and closing it for now but please feel free to comment here if you would like to continue this discussion. We also recommend heading over to our communities if you have questions that are not bug reports or feature requests. We hope we managed to help and thank you for using Gatsby!

@samponeill
Copy link
Author

samponeill commented Jan 22, 2021

@LekoArts thanks for taking the time to respond

Please can you address the platforms issue? Webapp is a known possible value according to the wiki but is not being allowed here

@samponeill
Copy link
Author

@LekoArts thanks for adding that in!

As for id – you say I need an id or url and I have a url but I'm still encountering an error message saying I need an id. Should it be url or id rather than requiring id no matter what?

"A valid ExternalApplicationResource dictionary MUST have platform and either an url or an id (or both)."
from W3 spec you referenced (emphasis mine)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: question or discussion Issue discussing or asking a question about Gatsby
Projects
None yet
2 participants