make sure to pass the failOnError option to base64 generation #29254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
vladar
suggested changes
Jan 29, 2021
vladar
added
topic: sharp
and removed
status: triage needed
Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
|
Thanks! Change is commited! |
ascorbic
pushed a commit
that referenced
this pull request
Feb 1, 2021
… base64 generation (#29254) * make sure to pass the failOnError option to base64 generation * Update packages/gatsby-plugin-sharp/src/index.js Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com> Co-authored-by: Dominik Voss <dominik.voss@check24.de> Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com> (cherry picked from commit bc0f5c8)
ascorbic
added a commit
that referenced
this pull request
Feb 1, 2021
… base64 generation (#29254) (#29290) * make sure to pass the failOnError option to base64 generation * Update packages/gatsby-plugin-sharp/src/index.js Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com> Co-authored-by: Dominik Voss <dominik.voss@check24.de> Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com> (cherry picked from commit bc0f5c8) Co-authored-by: Dom <dominikvoss@mailbox.org>
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The gatsby-image-sharp plugin accepts (among others) a
failOnErroroption. This option is not passed down properly during the creation of Base64 images. So if you send a "corrupted" file to it, it will fail, causing the whole build to fail.Documentation
Related Issues
Addresses #28203