Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-wordpress): auto-rename types named "Filter" #29718

Merged
merged 10 commits into from
Feb 26, 2021

Conversation

TylerBarnes
Copy link
Contributor

@TylerBarnes TylerBarnes commented Feb 23, 2021

Closes #29684

When a node type is named "Filter", Gatsby is using it's fields to make input args for some other fields. That should be fixed in core (https://gatsby.canny.io/ideas/p/node-types-named-filter-cause-graphql-input-arg-generation-problems) but in the meantime I've added a simple fix for WP users here.

The fix is https://github.com/gatsbyjs/gatsby/blob/fix/root-wp-field-breaks-for-some-sites/packages/gatsby-source-wordpress/src/steps/create-schema-customization/helpers.js#L23-L25

the other changes are a slight refactor to make debugging easier.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 23, 2021
@TylerBarnes TylerBarnes changed the title fix(gatsby-source-wordpress): auto-rename types named named "Filter" fix(gatsby-source-wordpress): auto-rename types named "Filter" Feb 23, 2021
@TylerBarnes TylerBarnes removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 23, 2021
@TylerBarnes TylerBarnes requested a review from sslotsky February 23, 2021 22:40
sslotsky
sslotsky previously approved these changes Feb 23, 2021
sslotsky
sslotsky previously approved these changes Feb 25, 2021
@TylerBarnes TylerBarnes merged commit fb225be into master Feb 26, 2021
@TylerBarnes TylerBarnes deleted the fix/root-wp-field-breaks-for-some-sites branch February 26, 2021 19:47
vladar pushed a commit that referenced this pull request Feb 27, 2021
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
(cherry picked from commit fb225be)
vladar pushed a commit that referenced this pull request Feb 27, 2021
… (#29815)

Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
(cherry picked from commit fb225be)

Co-authored-by: Tyler Barnes <tyler@gatsbyjs.com>
ascorbic pushed a commit that referenced this pull request Mar 1, 2021
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
(cherry picked from commit fb225be)
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WordPress settings can't be queried?
2 participants