Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsyby): improve error messages for errors outside of react" #30031

Merged
merged 3 commits into from
Mar 10, 2021

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Mar 5, 2021

Description

Updated the correct error message in develop so people know where to look

Before:
image

After:
image

Documentation

Related Issues

Fixes #30046

[ch26500]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 5, 2021
@@ -4,6 +4,9 @@ import { render, getNodeText, cleanup } from "@testing-library/react"

jest.mock(`../loader`, () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really dumb test but 🤷

packages/gatsby/cache-dir/loader.js Outdated Show resolved Hide resolved
@wardpeet wardpeet changed the title fix(gatsyby): improve error messages for erros outside of react" fix(gatsyby): improve error messages for errors outside of react" Mar 5, 2021
@wardpeet wardpeet added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 5, 2021
@bradlocking
Copy link

Any idea when we might see this land as a version bump?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gatsby ^3.0 doesn't display correct compilation error
3 participants