Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sitemap v4.1.0] "output" is not allowed to be empty #31378

Closed
mwskwong opened this issue May 12, 2021 · 1 comment
Closed

[Sitemap v4.1.0] "output" is not allowed to be empty #31378

mwskwong opened this issue May 12, 2021 · 1 comment
Labels
type: bug An issue or pull request relating to a bug in Gatsby

Comments

@mwskwong
Copy link

mwskwong commented May 12, 2021

Description

According to PR #31130 and Gatsby v3.5 release notes, it should now be possible to specify output: "" in gatsby-sitemap-plugin@4.1.0. Yet, it appears to reject an empty string value and still report the "output" is not allowed to be empty error, same as older versions.

Steps to reproduce

  1. Use any starter template
  2. Install gatsby-sitemap-plugin@4.1.0
  3. In gatsby-config.js, set the option output to ""
    i.e.
{
  resolve: "gatsby-plugin-sitemap",
  options: {
    output: ""
  }
}

Expected result

gatsby-sitemap-plugin@4.1.0 should accept output: "".

Actual result

It rejected the value and an error is promoted instead.

Environment


  System:
    OS: Windows 10 10.0.18363
    CPU: (12) x64 Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
  Binaries:
    Node: 15.14.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 7.11.1 - C:\Program Files\nodejs\npm.CMD
  Languages:
    Python: 3.9.4
  Browsers:
    Chrome: 90.0.4430.93
    Edge: Spartan (44.18362.449.0)
  npmPackages:
    gatsby: ^3.5.0 => 3.5.0 
    gatsby-plugin-emotion: ^6.5.0 => 6.5.0 
    gatsby-plugin-image: ^1.5.0 => 1.5.0 
    gatsby-plugin-manifest: ^3.5.0 => 3.5.0 
    gatsby-plugin-offline: ^4.5.0 => 4.5.0 
    gatsby-plugin-react-helmet: ^4.5.0 => 4.5.0 
    gatsby-plugin-robots-txt: ^1.6.2 => 1.6.2 
    gatsby-plugin-root-import: ^2.0.6 => 2.0.6 
    gatsby-plugin-sharp: ^3.5.0 => 3.5.0 
    gatsby-plugin-sitemap: ^4.1.0 => 4.1.0 
    gatsby-plugin-webpack-bundle-analyser-v2: ^1.1.22 => 1.1.21 
    gatsby-source-filesystem: ^3.5.0 => 3.5.0 
    gatsby-transformer-sharp: ^3.5.0 => 3.5.0 
  npmGlobalPackages:
    gatsby-cli: 3.0.0
flags: {
  FAST_DEV: true,
  DEV_SSR: true,
  PRESERVE_FILE_DOWNLOAD_CACHE: true,
  PRESERVE_WEBPACK_CACHE: true,
  PARALLEL_SOURCING: true
}
@mwskwong mwskwong added the type: bug An issue or pull request relating to a bug in Gatsby label May 12, 2021
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 12, 2021
@mwskwong mwskwong changed the title [Sitemap] "output" is not allowed to be empty [Sitemap v4.1.0] "output" is not allowed to be empty May 12, 2021
@mwskwong
Copy link
Author

Workaround

Set output to "/" or ".".

@gatsbyjs gatsbyjs locked and limited conversation to collaborators May 12, 2021
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 17, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

No branches or pull requests

2 participants