-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(babel-preset-gatsby): Updated README to include babel presets #35069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't pass reactRuntime and reactImportSource to babel-preset-gatsby in .babelrc.json, JSX is invalid in gatsby-browser.js. In order to validate these errors, I have added the presets according to the docs.
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Mar 7, 2022
Hey @oneknucklehead ! Thank you for the contribution. 😄 Per @LekoArts 's suggestion, could you add the change of the second bullet point here as well?
|
imjoshin
added
type: documentation
An issue or pull request for improving or updating Gatsby's documentation
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Mar 7, 2022
imjoshin
changed the title
Updated README.md to include babel presets
docs(babel-preset-gatsby): Updated README.md to include babel presets
Mar 7, 2022
Sure! but can you help me out? I can't figure out which gatsby-config file to make the changes to. |
@j0sh77 can you help me out? |
As of Gatsby 4.1 it has become necessary to set jsxruntime and jsxImportSource. Thus, added the said changes to the docs.
Update readme.md gatsby-config.md files
Hey @j0sh77 can you please review the changes? |
LekoArts
changed the title
docs(babel-preset-gatsby): Updated README.md to include babel presets
chore(babel-preset-gatsby): Updated README to include babel presets
Apr 1, 2022
LekoArts
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: documentation
An issue or pull request for improving or updating Gatsby's documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we don't pass reactRuntime and reactImportSource to babel-preset-gatsby in .babelrc.json, JSX is invalid in gatsby-browser.js. In order to validate these errors, I have added the presets according to the docs.
Related Issues
Fixes #34518