Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add peerDependencies to every plugin #3575

Closed
KyleAMathews opened this issue Jan 18, 2018 · 4 comments
Closed

Add peerDependencies to every plugin #3575

KyleAMathews opened this issue Jan 18, 2018 · 4 comments
Assignees
@tsriram
Labels
good first issue Issue that doesn't require previous experience with Gatsby help wanted Issue with a clear description that the community can help with.

Comments

@KyleAMathews
Copy link
Contributor

Going forward, we'll be doing every so often major releases for Gatsby but individual plugins might not need upgraded as the APIs they depend on won't have changed. We should prepare for that now by adding a peerDependencies for Gatsby to every plugin. Then when there is a breaking change that affects the plugin or there's a new major release of Gatsby, we update the peerDependencies for the plugin.
@KyleAMathews KyleAMathews added good first issue Issue that doesn't require previous experience with Gatsby help wanted Issue with a clear description that the community can help with. labels Jan 18, 2018
@tsriram
Copy link
Contributor

tsriram commented Jan 21, 2018

If it's still not taken up by anyone, I'd like to take this up.

@KyleAMathews
Copy link
Contributor Author

Nope, have at it!

@tsriram
Copy link
Contributor

tsriram commented Jan 21, 2018

Awesome! What version should be set as the peer dependency now - the latest one on npm v1.9.164?

@KyleAMathews
Copy link
Contributor Author

Just do ^1.0.0 to keep things simple.

@tsriram tsriram mentioned this issue Jan 21, 2018
Merged
@tsriram tsriram self-assigned this Feb 10, 2018
@chmac chmac mentioned this issue Mar 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsriram tsriram

Labels
good first issue Issue that doesn't require previous experience with Gatsby help wanted Issue with a clear description that the community can help with.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KyleAMathews @tsriram