-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-source-filesystem): Only generate hashes when a file has changed, and add an option for skipping hashing #37464
Merged
LekoArts
merged 9 commits into
gatsbyjs:master
from
FraserThompson:topics/source-filesystem-faster-hashing
Jan 17, 2023
Merged
feat(gatsby-source-filesystem): Only generate hashes when a file has changed, and add an option for skipping hashing #37464
LekoArts
merged 9 commits into
gatsbyjs:master
from
FraserThompson:topics/source-filesystem-faster-hashing
Jan 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her packages that use this, add tests
Update feature branch with latest from master
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Jan 13, 2023
LekoArts
added
topic: source-plugins
Relates to the Gatsby source plugins (e.g. -filesystem)
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Jan 16, 2023
LekoArts
suggested changes
Jan 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I'll change the README a little bit more later, so code wise I only have some small requests :)
packages/gatsby-source-filesystem/src/__tests__/create-file-node.js
Outdated
Show resolved
Hide resolved
packages/gatsby-source-filesystem/src/__tests__/create-file-node.js
Outdated
Show resolved
Hide resolved
…to fastHash setting
latest from master
LekoArts
approved these changes
Jan 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! A lot of people will benefit from that ❤️
This was referenced Jan 24, 2023
This was referenced Jan 25, 2023
This was referenced Jan 25, 2023
mwfrost
pushed a commit
to mwfrost/gatsby
that referenced
this pull request
Apr 20, 2023
…changed, and add an option for skipping hashing (gatsbyjs#37464) Co-authored-by: LekoArts <lekoarts@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generating an MD5 hash in
gatsby-source-filesystem
is quite an expensive operation for large files, and can increase build times significantly, as well as introduce other issues with open file handles.To mitigate this:
Documentation
I've added a section to the README explaining the new option. Not sure if what I wrote goes into sufficient detail (or too much detail) though.
Related Issues
Addresses #12011
Fixes #37425