Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Change deleteNode so it uses named arguments like rest of actions #4409

Closed
KyleAMathews opened this issue Mar 7, 2018 · 3 comments
Closed
Assignees

Comments

@KyleAMathews
Copy link
Contributor

This is the only action that uses two arguments — which kinda breaks some internal code which expects there to be only one argument.

@m-allanson
Copy link
Contributor

Should it just accept a nodeId?

The current signature is:

deleteNode = (nodeId: string, node: any, plugin: Plugin)

new signature?

deleteNode = (nodeId: string, plugin: Plugin)

@KyleAMathews
Copy link
Contributor Author

It should be ({ node }, plugin) — we have to send the whole node object because once the node is deleted, the node passed to the action is the only record we have left so it's needed for other internal systems to respond to the deletion.

@m-allanson
Copy link
Contributor

Done in #5222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants