Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Appveyor check is failing #5725

Closed
dennari opened this issue Jun 5, 2018 · 3 comments
Closed

[v2] Appveyor check is failing #5725

dennari opened this issue Jun 5, 2018 · 3 comments
Assignees
Labels
help wanted Issue with a clear description that the community can help with. type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change

Comments

@dennari
Copy link
Contributor

dennari commented Jun 5, 2018

For some reason the tests are not passing on Appveyor's Windows platform:

Summary of all failing tests
FAIL packages\gatsby-transformer-react-docgen\src\__tests__\on-node-create.js
  ● transformer-react-doc-gen: onCreateNode › should delicately remove doclets
    Error
      94 |       `An object hash of field (fix this @mention?) errors for the form.`
      95 |     )
    > 96 |     expect(types.ComponentProp[0].doclets).toEqual({
      97 |       type: `{Foo}`,
      98 |       default: `blue`,
      99 |     })
      Error: expect(received).toEqual(expected)
      
      Expected value to equal:
        {"default": "blue", "type": "{Foo}"}
      Received:
}
      
      Difference:
      
      - Expected
      + Received
      
        Object {
          "default": "blue",
      -   "type": "{Foo}",
",
        }
      at Object.it (packages/gatsby-transformer-react-docgen/src/__tests__/on-node-create.js:96:44)

Here's an example: https://ci.appveyor.com/project/KyleAMathews/gatsby/build/1.0.7490/job/dida9pt6nlly1yq6

@m-allanson m-allanson added help wanted Issue with a clear description that the community can help with. type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change labels Jun 5, 2018
@dennari
Copy link
Contributor Author

dennari commented Jun 5, 2018

Perhaps #5604 will fix this

@m-allanson
Copy link
Contributor

#5604 didn't solve it.. I've assigned to @pieh to take a look 🙏

@pieh
Copy link
Contributor

pieh commented Jun 7, 2018

So types.ComponentProp[0].doclets looks like this in windows - it doesn't remove \r which is part of default windows endline (\r\n):
image 2018-06-07 at 5 08 40 pm

@jquense what's the best place to fix this (I'm not familiar with gatsby-transformer-react-docgen)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issue with a clear description that the community can help with. type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

No branches or pull requests

3 participants