Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gatsby v2 Landing Page Broken on IE11 #6398

Closed
shelldandy opened this issue Jul 11, 2018 · 7 comments
Closed

Gatsby v2 Landing Page Broken on IE11 #6398

shelldandy opened this issue Jul 11, 2018 · 7 comments
Labels
help wanted Issue with a clear description that the community can help with. type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change

Comments

@shelldandy
Copy link
Contributor

v1 landing is fine, but v2 looks like this:

screen shot 2018-07-11 at 6 22 23 pm

@m-allanson m-allanson added help wanted Issue with a clear description that the community can help with. type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change labels Jul 12, 2018
@m-allanson
Copy link
Contributor

Oh dear, let's get that fixed. Thanks @shelldandy 👍

@anantoghosh
Copy link
Contributor

@m-allanson I made a pr for this.
But gatsby develop does not work on IE 11 after gatsby@beta.13, build still works. Is using develop in IE 11 supported? It has made testing on IE much harder.

SCRIPT5022: Objects are not valid as a React child (found: object with keys {$$typeof, type, key, ref, props, _owner, _store}). If you meant to render a collection of children, use an array instead.
invariant.js (49,5)
SCRIPT5022: Objects are not valid as a React child (found: object with keys {$$typeof, type, key, ref, props, _owner, _store}). If you meant to render a collection of children, use an array instead.
react-dom.development.js (16543,5)

I think it was after this commit 2fd9026 but I'm not sure

@pieh
Copy link
Contributor

pieh commented Jul 19, 2018

This was fixed in #6414 . Thanks @anantoghosh!

@pieh pieh closed this as completed Jul 19, 2018
@msachi
Copy link
Contributor

msachi commented Sep 6, 2018

@anantoghosh Did you find a way to get gatsby develop to work on IE? We are trying to fix an IE issue and it's difficult to debug in production.

@anantoghosh
Copy link
Contributor

@msachi develop does not work on ie. Maybe you could find something from this discussion #7003 (comment). You could try using using a custom babel config. All I can say is that the error is because of polyfills not being loaded when using develop

@shelldandy
Copy link
Contributor Author

but also on prod sometimes IE doesn't load at all and you can't properly debug since react is on production mode so the errors are not super friendly

@anantoghosh
Copy link
Contributor

Please create a separate issue so it could be tracked or continue discussion on #7003 if it seems relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issue with a clear description that the community can help with. type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

No branches or pull requests

5 participants