Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: First-Class Storybook Integration #7219

Closed
Undistraction opened this issue Aug 10, 2018 · 7 comments
Closed

Request: First-Class Storybook Integration #7219

Undistraction opened this issue Aug 10, 2018 · 7 comments
Labels
stale? Issue that may be closed soon due to the original author not responding any more.

Comments

@Undistraction
Copy link
Contributor

Undistraction commented Aug 10, 2018

Summary

It is currently pretty painful to integrate Storybook with Gatsby. I know there is some discussion here and there is a great starter here, but imho, storybook should be something that works out the box (or as close to it as possible). This could be in the form of an official plugin, but I personally think this should be fully integrated so users are provided out-of-the-box with:

  • Site
  • Testing
  • Styleguide
@madeleineostoja
Copy link

madeleineostoja commented Aug 17, 2018

👍 This would be great, but I think it should be provided as an official plugin rather than baked in. It's a rather opinionated feature, when there are other component library helpers out there that people might prefer to use.

EDIT: Just looked into that starter, looks like the kind of rigmarole you have to setup for hacking around Gatsby wouldn't be doable as a plugin. So yep would be awesome to have some kind of out-of-the-box support for this. Looks like Storybook is working on a concept of presets, if this becomes a thing adding a Gatsby one would be a no-brainer

@Undistraction
Copy link
Contributor Author

@seaneking Yes. I think ideally it would be a plugin, but it goes too deep (at least with the current API) for that to be viable.

I'm working on a new project at the moment with Gatsby and Styled Components hooked up to Storybook and backed by Jest tests and it really feels like its the promised land to me. We are going to take a look at integrating Chromatic which I think will be the icing on the cake.

@LekoArts
Copy link
Contributor

There's a guide for Storybook now: https://www.gatsbyjs.org/docs/visual-testing-with-storybook/

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Feb 6, 2019
@gatsbot
Copy link

gatsbot bot commented Feb 6, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

Thanks for being a part of the Gatsby community! 💪💜

@madeleineostoja
Copy link

Would be great to keep this open — the Gatsby Babel preset helped, but there's still a fair few hacky workarounds needed to get Storybook working, would be great to see if we can get tighter integration out of the box

@m-allanson m-allanson removed the stale? Issue that may be closed soon due to the original author not responding any more. label Feb 7, 2019
@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Feb 28, 2019
@gatsbot
Copy link

gatsbot bot commented Feb 28, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

Thanks for being a part of the Gatsby community! 💪💜

@gatsbot
Copy link

gatsbot bot commented Mar 11, 2019

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

Thanks again for being part of the Gatsby community!

@gatsbot gatsbot bot closed this as completed Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale? Issue that may be closed soon due to the original author not responding any more.
Projects
None yet
Development

No branches or pull requests

5 participants