-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll to top on push not working as expected #8217
Comments
@zslabs I'm unable to reproduce this on latest versions of |
Hey @kakadiadarpan thanks for the reply! Here's a gif of what I was talking about (sorry - would have been more helpful if I added that to begin with): Let me know if that helps better explain things. |
I am also having an issue with scrollToTop not working as expected. |
Thanks! Saw this was released in |
I am still seeing this issue on |
Maybe there is different issue @mfix22 - can you provide more info - reproduction repo / site etc? |
Unfortunately I can't provide a reproduction site at the moment /: but basically we have a footer that I equivalent on every page, so when we are scrolled to the very bottom, clicking any of the links in the footer changes the page contents correctly above the fold, but the page is still positioned on the footer itself. |
Description
This issue was discussed quite a bit in #3249 and fixed in #3775 but I realized leaving a comment there probably wasn't the best; so opening up an issue here to see if this needs a bit more investigation. As described in the PR comment, I'm not not consistently getting "scroll to top" behavior.
Steps to reproduce
If you scrunch up the deploy preview (so there's scrollable content in the about page) when I go to the homepage, scroll down just a bit in the nav and click "About", the page scroll is not at the top.
Expected result
Scroll to top
Actual result
Not scrolling to top 😢
Environment
Demo server provided by repo
The text was updated successfully, but these errors were encountered: