Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll to top on push not working as expected #8217

Closed
zslabs opened this issue Sep 17, 2018 · 10 comments
Closed

Scroll to top on push not working as expected #8217

zslabs opened this issue Sep 17, 2018 · 10 comments

Comments

@zslabs
Copy link
Contributor

zslabs commented Sep 17, 2018

Description

This issue was discussed quite a bit in #3249 and fixed in #3775 but I realized leaving a comment there probably wasn't the best; so opening up an issue here to see if this needs a bit more investigation. As described in the PR comment, I'm not not consistently getting "scroll to top" behavior.

Steps to reproduce

If you scrunch up the deploy preview (so there's scrollable content in the about page) when I go to the homepage, scroll down just a bit in the nav and click "About", the page scroll is not at the top.

Expected result

Scroll to top

Actual result

Not scrolling to top 😢

Environment

Demo server provided by repo

@kakadiadarpan
Copy link
Contributor

kakadiadarpan commented Sep 18, 2018

@zslabs I'm unable to reproduce this on latest versions of Chrome or Safari. I'm getting "scroll to top" behavior consistently (tried 10 times). It would be great if you could provide a screen recording of this issue.

@kakadiadarpan kakadiadarpan added the status: needs more info Needs triaging and reproducible examples or more information to be resolved label Sep 18, 2018
@zslabs
Copy link
Contributor Author

zslabs commented Sep 18, 2018

Hey @kakadiadarpan thanks for the reply! Here's a gif of what I was talking about (sorry - would have been more helpful if I added that to begin with):

kapture 2018-09-18 at 10 43 01

Let me know if that helps better explain things.

@williamtstanley
Copy link
Contributor

I am also having an issue with scrollToTop not working as expected.

@kakadiadarpan kakadiadarpan added status: inkteam to review and removed status: needs more info Needs triaging and reproducible examples or more information to be resolved labels Sep 19, 2018
@KyleAMathews
Copy link
Contributor

@pieh has a PR open with a fix for this #8359

Sorry! 🙏

@zslabs
Copy link
Contributor Author

zslabs commented Sep 20, 2018

Yuh

@zslabs
Copy link
Contributor Author

zslabs commented Sep 21, 2018

Thanks! Saw this was released in 2.0.7!

@zslabs zslabs closed this as completed Sep 21, 2018
@mfix22
Copy link
Contributor

mfix22 commented Sep 24, 2018

I am still seeing this issue on 2.0.8. Are there other steps I need to take when upgrading?

@pieh
Copy link
Contributor

pieh commented Sep 24, 2018

Maybe there is different issue @mfix22 - can you provide more info - reproduction repo / site etc?

@mfix22
Copy link
Contributor

mfix22 commented Sep 24, 2018

Unfortunately I can't provide a reproduction site at the moment /: but basically we have a footer that I equivalent on every page, so when we are scrolled to the very bottom, clicking any of the links in the footer changes the page contents correctly above the fold, but the page is still positioned on the footer itself.

@mfix22
Copy link
Contributor

mfix22 commented Sep 24, 2018

@pieh it ended up being the same issue as here: #631
Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants