[gatsby-plugin-sharp] add option to use mozjpeg #8621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, pushed merge commit to force restart tests that were broken few days ago and will be testing locally with feature flag enabled |
pieh
approved these changes
Oct 3, 2018
pieh
pushed a commit
that referenced
this pull request
Oct 16, 2018
* update lockfile after imagemin-mozjpeg was added to gatsby-plugin-sharp/package.json in #8621 * sizes for srcSet can be configured * use ternary * add check to see if array exists * change name to customSizes * add documentation and description * add test for custom sizes * remove unnecessary array cloning * change name to srcSetBreakpoints * throw on negative value in srcSetBreakpoints * ensure maxWidth is in the breakpoints * add test to check that no breakpoints wider than the original width are added * ensure no duplicate breakpoints are added * ensure that maxWidth is a positive int * check for 0 as well as negative ints * expand documentation to let user know maxWidth will be added srcSetBreakpoints * fix error message
jedrichards
pushed a commit
to jedrichards/gatsby
that referenced
this pull request
Nov 1, 2018
* update lockfile after imagemin-mozjpeg was added to gatsby-plugin-sharp/package.json in gatsbyjs#8621 * sizes for srcSet can be configured * use ternary * add check to see if array exists * change name to customSizes * add documentation and description * add test for custom sizes * remove unnecessary array cloning * change name to srcSetBreakpoints * throw on negative value in srcSetBreakpoints * ensure maxWidth is in the breakpoints * add test to check that no breakpoints wider than the original width are added * ensure no duplicate breakpoints are added * ensure that maxWidth is a positive int * check for 0 as well as negative ints * expand documentation to let user know maxWidth will be added srcSetBreakpoints * fix error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to use MozJPEG for image compression.
As proposed in #8556 we use an environmental variable GATSBY_JPEG_ENCODER=MOZJPEG for this.
The PR finished the already closed WIP PR #5682 and fixes PR #8586.