feat: use hashed folder names instead of filenames. closes #6232 #8808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sekhmet
commented
Oct 4, 2018
| expect(result.src.indexOf(file.name)).toBe(8) | ||
| expect(result.srcSet.indexOf(file.name)).toBe(8) | ||
| expect(result.src.indexOf(file.name)).toBe(19) | ||
| expect(result.srcSet.indexOf(file.name)).toBe(19) |
There was a problem hiding this comment.
Those had to be changed because the strings changed from:
/static/test-1234-7bb67.png
to
/static/1234/7bb67/test.png
So now file name starts at index 19.
There was a problem hiding this comment.
maybe we should adjust this test to test that final part of path is same as source file? i.e.
expect(path.parse(result.src).name).toBe(file.name) ?
There was a problem hiding this comment.
and similiar with srcSet - probably would need some processing to split by , and then space or something like that
DSchau
approved these changes
Oct 29, 2018
|
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
(gatsbyjs#8808) **Related issue:** gatsbyjs#6232 @LekoArts mentioned two ways of implementing it (one that concatenates `argsDigest` with `contentDigest` and other that uses `contentDigest` as one directory and `argsDigest` as another child so images are grouped together and it limits the number of directories in `static` directory). This PR implements the latter. ### Performance impact I measured the performance of original solution and one from this PR 5 times (and ignoring first build after changing gatsby version) for each (every time cleaning the cache) by running `gatsby build` on example [using-gatsby-image](https://github.com/gatsbyjs/gatsby/tree/master/examples/using-gatsby-image). Tested on Linux, Ryzen 2700X and 970 EVO. #### Original (`2.0.18`) - `14.70` - `14.08` - `13.65` - `14.22` - `13.80` **Average:** `14.09` #### This PR: - `13.77` - `13.51` - `13.61` - `13.78` - `13.66` **Average:** `13,666` So this results in 3% improvement in build times (it might be just luck, but at least it doesn't increase build time).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #6232
@LekoArts mentioned two ways of implementing it (one that concatenates
argsDigestwithcontentDigestand other that usescontentDigestas one directory andargsDigestas another child so images are grouped together and it limits the number of directories instaticdirectory). This PR implements the latter.Performance impact
I measured the performance of original solution and one from this PR 5 times (and ignoring first build after changing gatsby version) for each (every time cleaning the cache) by running
gatsby buildon example using-gatsby-image.Tested on Linux, Ryzen 2700X and 970 EVO.
Original (
2.0.18)14.7014.0813.6514.2213.80Average:
14.09This PR:
13.7713.5113.6113.7813.66Average:
13,666So this results in 3% improvement in build times (it might be just luck, but at least it doesn't increase build time).