Skip to content

Commit 57c6c0e

Browse files
committed
fix(numberFilter): format large numbers correctly
format large number to correct form instead of NAN.00 currently. in previous code when first time we add the exponent with fractionSize (number.toString()+'e'+fractionsize) and then convert it to an integer using , +(number.toString()+'e'+fractionsize) when the number is very large and number will be represented by using exponent. for example 12345868059685210000 will be represented by 1.234586805968521e+21. as getting string in exponent is not handles, we get the number as NAN. Handle when the number is being represented in exponent form, by adjusting exponent of number with fraction size: Closes angular#8674
1 parent 8863b9d commit 57c6c0e

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

src/ng/filter/filters.js

+7-1
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,12 @@ function numberFilter($locale) {
118118
};
119119
}
120120

121+
function getExponentString(numberString,fractionSize) {
122+
var numberArray = numberString.split('e'),
123+
fractionUsed = +fractionSize;
124+
return (numberArray[0] + 'e' + (numberArray[1] ? (+numberArray[1] + fractionUsed) : fractionUsed));
125+
}
126+
121127
var DECIMAL_SEP = '.';
122128
function formatNumber(number, pattern, groupSep, decimalSep, fractionSize) {
123129
if (number == null || !isFinite(number) || isObject(number)) return '';
@@ -151,7 +157,7 @@ function formatNumber(number, pattern, groupSep, decimalSep, fractionSize) {
151157
// safely round numbers in JS without hitting imprecisions of floating-point arithmetics
152158
// inspired by:
153159
// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/round
154-
number = +(Math.round(+(number.toString() + 'e' + fractionSize)).toString() + 'e' + -fractionSize);
160+
number = +(getExponentString(Math.round(+(getExponentString(number.toString(),fractionSize))).toString(),-fractionSize));
155161

156162
var fraction = ('' + number).split(DECIMAL_SEP);
157163
var whole = fraction[0];

test/ng/filter/filtersSpec.js

+6
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,12 @@ describe('filters', function() {
5959
expect(num).toBe('1.1112');
6060
});
6161

62+
it('should format large number',function() {
63+
pattern.gsize = 2;
64+
var num = formatNumber(12345868059685210000, pattern, ',', '.', 2);
65+
expect(num).toBe('12,345,868,059,685,210,000.00');
66+
});
67+
6268
it('should format according different separators', function() {
6369
var num = formatNumber(1234567.1, pattern, '.', ',', 2);
6470
expect(num).toBe('1.234.567,10');

0 commit comments

Comments
 (0)