Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Tortoise as transport protocol for Phoenix Channels #109

Open
chintan-mishra opened this issue May 31, 2019 · 1 comment

Comments

@chintan-mishra
Copy link

Pre-requisite

Phoenix channels currently support WebSockets and Long Polling. However, Phoenix application is not limited by these and its creators have made it possible to add other transport methods like MQTT, STOMP, HTML5 SSE, etc.

Proposal

Tortoise abstracts the nuances of MQTT making it a breeze to add MQTT in any project. Supporting Phoenix channels will be a step closer towards it.

Further

  • Implementing this is essentially following the behavior outlined in Phoenix.Socket.Transport documentation.

  • I was planning on starting a PR. However, after reading New Websocket transport #106, I figured it'd be best to wait for MQTT v5 and WebSocket support before proceeding. I will leave this here for consideration in the future.

@gausby
Copy link
Owner

gausby commented Jun 3, 2019

Thanks for the feature request. Let's see what we can do with the coming Tortoise. I will see if I can get a rc out sooner than later. Sorry it takes some time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants