Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no assets on musl-linux: Bug in version 0.9.0: FileNotFoundError: cannot find mask #32

Closed
davincent-ucl opened this issue Sep 13, 2024 · 14 comments

Comments

@davincent-ucl
Copy link

Hello,
It seems that there is an issue with version 0.9.0 released yesterday. Creating a new mask results in a FileNotFoundError.

>>> from roaring_landmask import RoaringLandmask
>>> l = RoaringLandmask.new()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
FileNotFoundError: cannot find mask
@gauteh
Copy link
Owner

gauteh commented Sep 13, 2024

Hi, how did you install the package?

ping: @TheSylex

@davincent-ucl
Copy link
Author

davincent-ucl commented Sep 13, 2024

The package is a requirement from opendrift and is installed during the installation of opendrift.
I got the same issue when installing roaring_landmask with pip install
specifying the version 0.8.0 fix the issue

@gauteh
Copy link
Owner

gauteh commented Sep 13, 2024

Did you install opendrift using pip?

@davincent-ucl
Copy link
Author

yes

@gauteh
Copy link
Owner

gauteh commented Sep 13, 2024

Which platform are you on? We usually recommend conda for opendrift, because dependencies are easier to get right: https://opendrift.github.io/install.html

There's another issue with enough space on pypi for this package: #31 . Some platforms got a version without the assets included, so I have yanked version 0.9.0 until this issue is fixed.

@davincent-ucl
Copy link
Author

It's a docker image based on ubuntu:jammy.

@gauteh
Copy link
Owner

gauteh commented Sep 13, 2024

Ok. I think the assets are missing for the musl builds, probably better to install from source if you use pip on those platforms.

@gauteh gauteh changed the title Bug in version 0.9.0: FileNotFoundError: cannot find mask no assets on musl-linux: Bug in version 0.9.0: FileNotFoundError: cannot find mask Sep 13, 2024
@davincent-ucl
Copy link
Author

Thank you for your help

@TheSylex
Copy link

@gauteh all I do to install the package is pip install .
I can try to help tho

@TheSylex
Copy link

Okay, I'm a dumbass, it is in fact giving a problem now about not finding the mask for me too

@TheSylex
Copy link

@gauteh do you have any means for faster comms? discord/slack/gitter idk

@TheSylex
Copy link

Installing from local is fine, doing pip install . and then creating a mask works perfectly.
However as @davincent-ucl mentioned, installing through pypi gives the error of not finding the mask. So I'd assume this may be related to the publishing actions.
I do not have experience with that but I can still try to help, ping me whenever you need smth.

@gauteh
Copy link
Owner

gauteh commented Sep 16, 2024

I yanked the 0.9.0 release from pypi, we're not able to publish a correct version there until #31 is fixed. The only wheels that were published where macos ones (large enough to contain the masks) and musl-wheels, too small to contain the masks. Which probably means you are on a musl-platform of sorts? I don't think we should distribute those wheels, people can install from source on those platforms (or use conda).

@gauteh
Copy link
Owner

gauteh commented Sep 29, 2024

I have pushed a new version without the faulty wheels, the package should now be built from source.

@gauteh gauteh closed this as completed Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants