Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate netmd-js #31

Open
gavinbenda opened this issue Apr 22, 2020 · 2 comments
Open

Integrate netmd-js #31

gavinbenda opened this issue Apr 22, 2020 · 2 comments
Labels
help wanted Extra attention is needed Upstream Issue Bug likely exists in an upstream library

Comments

@gavinbenda
Copy link
Owner

gavinbenda commented Apr 22, 2020

https://github.com/cybercase/netmd-js is a JS port of netmdcli - this solves quite a few issues regarding having to bundle pre-compiled executives, and is a direct plug-in replacement that will work seamlessly with the platinum-md codebase.

This had a dependency on https://github.com/thegecko/webusb supporting the "Select USB" dialog in Electron. Issue has been opened here: thegecko/webusb#66 and mentioned here also: electron/electron#14545

@gavinbenda gavinbenda added help wanted Extra attention is needed Upstream Issue Bug likely exists in an upstream library labels Apr 22, 2020
@Invictaz
Copy link

Invictaz commented Apr 22, 2020

@cybercase I hope you are reading about the Electron issue. What I'm worried about is that Platinum-MD will rely too much on Chromium as it takes on parts from WebMD. Then this will no longer work on older pc systems. Platinum-MD is using Electron which is dangerous by itself already. I opted for the QHiMDTransfer route since QT is working fine on my older pc, however there are no newer windows builds yet because of a missing Travis configuration. That's why I ask you guys to develop Platinum-MD / WebMD further to have an alternative for my phone.

linux-minidisc/linux-minidisc@43a0119

@Invictaz
Copy link

Also Gavin it might rely on WebUSB which is a security risk according to Mozilla. Platinum-MD for now is safe as it runs isolated from the internet browser

cybercase/webminidisc#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Upstream Issue Bug likely exists in an upstream library
Projects
None yet
Development

No branches or pull requests

2 participants