-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DefaultFormatter.EnableRequests and EnableResponses #159
Comments
Hello @gavv, Could you please assign this one to me? Thanks ;) |
Sure, thanks! |
@gdguesser hi, do you still plan to work on this? |
Hey @gavv, Thank you for checking in on the task. My apologies for not responding sooner, but I had to move to a new apartment. I am still fully committed to completing the task, but if you find that someone else is interested in it, I'm more than happy to let them take over. I appreciate your understanding, and I look forward to contributing to the project 🙂. |
No worries, take your time. People often abandon tasks, so I usually ping after a month or so. Good luck with the new apartment :) |
Created follow-up issue: #343 |
Add two flags
EnableRequests
andEnableResponses
toDefaultFormatter
, which enable printinghttp.Request
andhttp.Response
on failure. New flags should be disabled by default.Request and response instances are already present in
AssertionContext
passed to formatter. Formatted request and response should be added toFormatData
and used in failure template. Formatting can be done usinghttputil
, like we do it inDebugPrinter
.Formatted response should include round trip time (again like in
DebugPrinter
).Related discussion: #137
See also #160.
The text was updated successfully, but these errors were encountered: