Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Environment.List and Find #259

Closed
gavv opened this issue Feb 1, 2023 · 2 comments · Fixed by #301
Closed

Add Environment.List and Find #259

gavv opened this issue Feb 1, 2023 · 2 comments · Fixed by #301
Assignees
@nhAnik
Labels
feature New feature or request good first issue Good for newcomers help wanted Contributions are welcome
Milestone
v2

Comments

@gavv
Copy link
Owner

gavv commented Feb 1, 2023

Add two methods to Environment:

  • List - returns a sorted slice of keys
  • Find - accepts a glob pattern and returns a sorted slice of keys that match pattern

Methods should have documentation comment with code example and be covered by tests.
@gavv gavv added feature New feature or request help wanted Contributions are welcome good first issue Good for newcomers labels Feb 1, 2023
@nhAnik
Copy link
Contributor

nhAnik commented Feb 19, 2023

Hi @gavv , can I work on this?

@gavv
Copy link
Owner Author

gavv commented Feb 19, 2023

Sure! Thank you

@nhAnik nhAnik mentioned this issue Feb 21, 2023
Merged
@gavv gavv closed this as completed in #301 Feb 22, 2023
@gavv gavv added this to the v2 milestone Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nhAnik nhAnik

Labels
feature New feature or request good first issue Good for newcomers help wanted Contributions are welcome
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

Add Environment.List and Find nhAnik/httpexpect
2 participants
@gavv @nhAnik