Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significantly lower RTF when state logging enabled after upgrading to gazebo 8.3 #2425

Closed
osrf-migration opened this issue Feb 13, 2018 · 7 comments
Labels
bug Something isn't working critical

Comments

@osrf-migration
Copy link

Original report (archived issue) by Deanna Hood (Bitbucket: d_hood).


State logging always lowers RTF a bit for ARIAC, but the latest releases have significantly impacted it.

Before, gazebo 8.2:

  • without state logging: RTF 0.95

roslaunch osrf_gear sample_environment.launch

  • with state logging: RTF 0.65

roslaunch osrf_gear sample_environment.launch state_logging:=true


After, gazebo 8.3 or gazebo 7.11:

  • without state logging: RTF 0.91
  • with state logging: RTF 0.09

I am aware of https://osrf-migration.github.io/gazebo-gh-pages/#!/osrf/gazebo/pull-requests/2608 that was merged during the latest release cycle, but I thought that was just targeting the gz log --echo tool, not logging itself. The lower RTF might be an unintended side effect of that PR, or from a different one altogether.

@osrf-migration
Copy link
Author

Original comment by Deanna Hood (Bitbucket: d_hood).


Most of my issues are specific to logging with the UR10 for ARIAC. I've confirmed that this effect occurs even without a ur10 in the environment, just from other models moving around.

@osrf-migration
Copy link
Author

Original comment by Jordan Liviero (Bitbucket: jliviero).


We have seen the same issue running the empty_world.launch file from gazebo_ros. Again, it seems to be tied to robot movement specifically, and disabling logging "fixes" it.

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


This is extremely bad!

record.gif

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


  • changed priority from "major" to "critical"

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


The problem was introduced on commit 3c47f4d. Calling sdf::initFile at every iteration is a really bad idea.

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


Pull request #2885 should solve this issue.

While investigating I ran into issue #2428... Pull request #2608 created a lot of problens 😕

@osrf-migration
Copy link
Author

Original comment by Deanna Hood (Bitbucket: d_hood).


  • changed state from "new" to "resolved"

fixed by https://osrf-migration.github.io/gazebo-gh-pages/#!/osrf/gazebo/pull-requests/2885 thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical
Projects
None yet
Development

No branches or pull requests

1 participant