Temporary GUI light has different angle than when it is added to the scene

[peci1]

With #2947 merged, it is now even more apparent that the temporary spot light used in GUI when interactively adding lights has wrong "shining angle":

light_visual.mp4

light_visual2.mp4

As can be seen in the videos, the wrong size now affects both the light source and the visual (i.e. the visual's size is correct regarding the temporary light's size).

Or is it just so that the temporary light has different default properties than the default added light?

[peci1]

If I Ctrl+C and Ctrl+V an existing spot light, the temporary light's size is correct.

[peci1]

It seems it's because GUI doesn't actually set the inner/outer angle of the OGRE light, so it uses its defaults: 0.52/0.7 rad, instead of 0.6/1.0 rad used in the cached message that is published to the factory.

https://github.com/OGRECave/ogre/blob/56833c49119da275669cc1c168fa53c0e5ed1d65/OgreMain/src/OgreLight.cpp#L46-L47

https://github.com/osrf/gazebo/blob/2f4d1fa5d63a6ed307d0894a0940e6dbda9473c6/gazebo/gui/LightMaker.cc#L196-L197

[peci1]

Directional temporary light seems to have wrong attenuation:

directional_light.mp4

[peci1]

Fixed by #2982.