Skip to content
This repository has been archived by the owner on Feb 3, 2025. It is now read-only.

Remove using namespace SimTK to fix compatibility with abseil 20230802 #3347

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

traversaro
Copy link
Collaborator

🦟 Bug fix

Fixes #3346

Summary

In gazebo/physics/simbody/SimbodyPhysics.cc using namespace SimTK was used, that brought in the global namespace functions such as operator<= that created conflicts with some version of abseil (that is a transitive dependency via protobuf). For clarity and consistency with the rest of the codebase, using namespace SimTK was removed and replaced with explicity use of the namespace SimTK::.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

@traversaro traversaro changed the title Remove using namespace SimTK Remove using namespace SimTK to fix compatibility with abseil 20230802 Sep 15, 2023
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS CI failed due to graphviz, but I merged with gazebo11 locally, and it compiles, so that's enough for me

@scpeters scpeters merged commit 23a3c5a into gazebosim:gazebo11 Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants