fix: Don't divide time by zero if single stepping. #3352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
traversaro
approved these changes
Oct 12, 2023
|
Can we merge this ? |
|
@ahcorde as the original author of the code, would you like to double check this fix? Thanks! |
iche033
approved these changes
Oct 26, 2023
scpeters
approved these changes
Nov 8, 2023
|
thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When stepping, the console always showed a warning "[gzserver-6] [Err] [Time.cc:684] Time divide by zero".
This commit fixes the warning, caused by a check on a wrong variable.