Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release for ign-fuel-tools4/Citadel? #189

Closed
traversaro opened this issue Jun 11, 2021 · 2 comments
Closed

New release for ign-fuel-tools4/Citadel? #189

traversaro opened this issue Jun 11, 2021 · 2 comments
Labels
🏰 citadel Ignition Citadel enhancement New feature or request

Comments

@traversaro
Copy link
Contributor

traversaro commented Jun 11, 2021

Desired behavior

Hi everyone! For Gazebo 11 Windows packaging, it would be nice to make a release of the ign-fuel-tools4 branch, as it includes a critical bug fix for Windows: #178 . The required changes in ignition-common3 (gazebosim/gz-common#197) were already release in 3.13 (see https://github.com/ignitionrobotics/ign-common/tags).

cc @Tobias-Fischer

Alternatives considered

An alternative we tried in conda-forge/libignition-fuel-tools-feedstock#32 (comment) was to backport the patch to an earlier release, but unfortunately it does not apply cleanly.

Implementation suggestion

I guess following the standard release process will be ok.

Additional context

This came out in conda-forge/libignition-fuel-tools-feedstock#32 (comment) .

@Tobias-Fischer
Copy link

Seems like this can be closed - thanks @chapulina!

@ahcorde ahcorde closed this as completed Jun 21, 2021
@traversaro
Copy link
Contributor Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants