You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed some fields that would be nice to add to the *ClickToScene events in #209 (comment), but this breaks ABI since we aren't using the PIMPL pattern.
Desired behavior
I noticed some fields that would be nice to add to the
*ClickToScene
events in #209 (comment), but this breaks ABI since we aren't using the PIMPL pattern.So, we should use PIMPL in this header and move the implementations to a
src/GuiEvents.cc
file.Alternatives considered
Keep it as is and only add new fields in unreleased code. This is less flexible.
Implementation suggestion
See src/Application.cc for an example.
Additional context
https://en.cppreference.com/w/cpp/language/pimpl
The text was updated successfully, but these errors were encountered: