Fixes warnings about onFoo connections in Qt QML #493
Conversation
Signed-off-by: Michael Carroll <michael@openrobotics.org>
|
I believe I introduced one of these test failures, do not merge. |
| @@ -101,11 +101,11 @@ ApplicationWindow | |||
| // C++ signals to QML slots | |||
| Connections { | |||
| target: MainWindow | |||
| onNotify: { | |||
| function onNotify(_message) { | |||
There was a problem hiding this comment.
Unfortunately, according to this commit message, this syntax is not available for Qt 5.12 which is the version for focal. A suggestion to look into is disable the warning or figure out how to call these functions from C++ code
There was a problem hiding this comment.
If we aren't planning on keeping focal support for harmonic, I can retarget to main, at least.
There was a problem hiding this comment.
I don't think there have been discussions or decisions on this yet
There was a problem hiding this comment.
I think the plan is to support focal and jammy for harmonic. https://github.com/gazebosim/docs/pull/324/files#diff-a056469a43d02c042f0ca8d049d90ae664ceffca6a9803b6520617b3fdbdd61e
There was a problem hiding this comment.
From the commit message @jennuine linked, perhaps we can disable the warning using QLoggingCategory::setFilterRules("qt.qml.connections=false");?
There was a problem hiding this comment.
From the commit message @jennuine linked, perhaps we can disable the warning using
QLoggingCategory::setFilterRules("qt.qml.connections=false");?
Apologies, I missed this message but thanks for taking care of it 🙇♀️
|
Should we close this for now and reopen when we're on a version of gz-gui that doesn't support Focal? |
|
Sounds good to me. |
|
Fixed in #534 |
🦟 Bug fix
Partially fixes #481
Split from #404
Summary
Cleans up warnings from Qt in the style of:
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.